Fix annotation default target warnings in enum constructors#602
Open
gioalex07 wants to merge 2 commits intoVREMSoftwareDevelopment:mainfrom
Open
Fix annotation default target warnings in enum constructors#602gioalex07 wants to merge 2 commits intoVREMSoftwareDevelopment:mainfrom
gioalex07 wants to merge 2 commits intoVREMSoftwareDevelopment:mainfrom
Conversation
Add explicit @param: target to @stringres, @DrawableRes and @ColorRes annotations on enum constructor parameters to suppress KT-73255 warnings. Kotlin 2.x will apply these annotations to both parameter and field by default in a future release; this change opts in to the parameter-only behavior explicitly. Affected files: WiFiBand, Strength, WiFiSecurity, WiFiStandard, WiFiWidth
Owner
|
Thanks for the contribution.
Please update the PR with real‑device testing details so review can continue. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #602 +/- ##
=========================================
Coverage 97.83% 97.83%
Complexity 975 975
=========================================
Files 121 121
Lines 2581 2581
Branches 211 211
=========================================
Hits 2525 2525
Misses 19 19
Partials 37 37 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@param:target to@StringRes,@DrawableResand@ColorResannotations on enum constructor parameters.What does this implement/fix?
Kotlin 2.x introduced a warning when
@StringRes,@DrawableResor@ColorResare applied to enum constructorparameters without an explicit annotation target. In a future release, these annotations will be applied to both
the parameter and the backing field by default. This change opts in to the parameter-only behavior explicitly
using the
@param:target, silencing the warning and future-proofing the code.Affected files:
wifi/band/WiFiBand.kt—@param:StringReswifi/model/Strength.kt—@param:DrawableRes,@param:ColorReswifi/model/WiFiSecurity.kt—@param:DrawableRes,@param:StringReswifi/model/WiFiStandard.kt—@param:StringRes(x2)wifi/model/WiFiWidth.kt—@param:StringResDoes this close any issues?
How was this tested?